72485[!!!][TASK] Deny inline JavaScript in FormEngine's requireJsModules
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/backend/Classes/Form/AbstractNode.php+2 −4
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+14 −50
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96158-RemoveSupportForInlineJavaScriptInFieldChangeFunc.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96221-DenyInlineJavaScriptInFormEnginesRequireJsModules.rstnew+67 −0
Review log 810
-
Oliver Hader uploaded patch set 1 12/03/21, 14:05
-
core-ci voted on patch set 1 V +1 12/03/21, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20500
-
Oliver Hader uploaded patch set 2 01/12/22, 11:57
-
Oliver Hader commented on patch set 2 01/12/22, 11:58
This change is ready for review. -
Oliver Hader wrote 01/12/22, 11:58
Topic set to inline-javascript -
core-ci voted on patch set 2 V +1 01/12/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21965
-
Benni Mack voted on patch set 2 V +1 CR +1 01/12/22, 15:38
-
Benjamin Franzke voted on patch set 2 CR +1 01/12/22, 15:45
-
Benjamin Franzke voted on patch set 2 V +2 CR +2 01/12/22, 15:51
-
Benjamin Franzke merged patch set 3 01/12/22, 15:51