Review main Merged Breaking

72485[!!!][TASK] Deny inline JavaScript in FormEngine's requireJsModules

Oliver Hader CR +2 V +2 Normal +84 −55 updated 01/12/22, 15:51

Commit message

Custom FormEngine components loading additional RequireJS modules
must use corresponding JavaScriptModuleInstruction instances to
declare modules and optional method invocations.

Assigning scalar values to FormEngine node section 'requireJsModules'
(e.g. used for arbitrary inline JavaScript callbacks) is not possible
anymore and will throw a LogicException.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 810

  1. Oliver Hader uploaded patch set 1 12/03/21, 14:05

  2. core-ci voted on patch set 1 V +1 12/03/21, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20500

  3. Oliver Hader uploaded patch set 2 01/12/22, 11:57

  4. Oliver Hader commented on patch set 2 01/12/22, 11:58

    This change is ready for review.
  5. Oliver Hader wrote 01/12/22, 11:58

    Topic set to inline-javascript
  6. core-ci voted on patch set 2 V +1 01/12/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21965

  7. Benni Mack voted on patch set 2 V +1 CR +1 01/12/22, 15:38

  8. Benjamin Franzke voted on patch set 2 CR +1 01/12/22, 15:45

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/12/22, 15:51

  10. Benjamin Franzke merged patch set 3 01/12/22, 15:51