Review main Merged

72487[TASK] runTests.sh: Don't mount home, passwd, group

Christian Kuhn CR +2 V +2 Normal +28 −168 updated 12/06/21, 14:54

Commit message

The patch changes runTests.sh and the container
definition to avoid mounting users home, /etc/passwd
and /etc/group. yarn based setups need some special
treatment but in the end bow to shell power, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 712

  1. Christian Kuhn uploaded patch set 1 12/03/21, 14:52

  2. core-ci voted on patch set 1 V +1 12/03/21, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20502

  3. core-ci commented on patch set 1 12/03/21, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20504

  4. Christian Kuhn commented on patch set 1 CR -1 12/03/21, 21:21

  5. Christian Kuhn uploaded patch set 2 12/05/21, 17:20

  6. core-ci voted on patch set 2 V +1 12/05/21, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20608

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 12/05/21, 17:53

  8. core-ci voted on patch set 2 V -1 12/05/21, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20612

  9. core-ci voted on patch set 2 V +1 12/05/21, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20612

  10. Jochen Roth voted on patch set 2 V +1 CR +1 12/06/21, 10:22

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 12/06/21, 14:54

  12. Christian Kuhn merged patch set 3 12/06/21, 14:54