Review main Merged Breaking

72489[!!!][TASK] Remove TSFE->ATagParams

Oli Bartsch CR +2 V +2 Easy +1 −17 updated 12/03/21, 16:51

Commit message

The public property `ATagParams` in
TypoScriptFrontendController was just a
copy of $TSFE->config[config][ATagParams].

The mentioned config option should be
used directly. Therefore the `ATagParams`
property is now removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 12/03/21, 15:25

  2. core-ci voted on patch set 1 V +1 12/03/21, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20507

  3. Nikita Hovratov commented on patch set 1 12/03/21, 16:20

    Add the breaking rst here too? typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php
  4. Oli Bartsch commented on patch set 1 12/03/21, 16:22

  5. Nikita Hovratov commented on patch set 1 V +1 CR +1 12/03/21, 16:35

    Reply

    Oh, well then.
  6. Benni Mack voted on patch set 1 V +2 CR +2 12/03/21, 16:51

  7. Benni Mack merged patch set 2 12/03/21, 16:51