Review main Merged

72492[TASK] Improve overall readability of sys ext README files

Tom Warwick CR +2 V +2 Normal +71 −75 updated 12/21/21, 11:15

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 57

Show 37 more files

Review log 2328

Show 3 earlier messages
  1. Tom Warwick uploaded patch set 1 12/03/21, 16:14

  2. Susi Moog voted on patch set 1 CR +1 12/03/21, 16:16

  3. Mathias Brodala commented on patch set 1 CR -1 12/03/21, 16:17

    These should be updated in ext_emconf.php and composer.json to stay in sync.
  1. Mathias Brodala commented on patch set 1 12/03/21, 16:18

    Reply

    See https://review.typo3.org/c/Packages/TYPO3.CMS/+/72288 where a lot of work was put into this.
  2. Susi Moog wrote 12/03/21, 16:20

    Removed Code-Review+1 by Susanne Moog <look@susi.dev>
  3. Susi Moog commented on patch set 1 12/03/21, 16:22

    Reply

    True, didn't see the other change - I'd say the texts are fine here and can be copied without the rst formatting to the other files.
  4. Tom Warwick commented on patch set 1 12/03/21, 16:23

    Ok I will copy the content to emconf & composer.json (preserving the module name) without the formatting.
  5. core-ci voted on patch set 1 V +1 12/03/21, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20514

  6. Lina Wolf commented on patch set 1 CR -1 12/04/21, 09:01

    I agree, we need the same content in all 3 files.
  7. Tom Warwick uploaded patch set 2 12/10/21, 14:27

  8. core-ci voted on patch set 2 V +1 12/10/21, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20944

  9. Tom Warwick abandoned the change 12/20/21, 16:14

  10. Benni Mack restored the change 12/21/21, 07:52

  11. Susi Moog uploaded patch set 3 12/21/21, 07:59

  12. Susi Moog commented on patch set 3 12/21/21, 08:05

    Just fixed a few more files: - Removed belog guilabel (tested with github, looks ugly as github is unable to interpret our directives) - Changed spelling of CKEditor (uppercase E) - Added missing file
  13. Susi Moog commented on patch set 3 12/21/21, 08:05

    Reply

    Done
  14. core-ci voted on patch set 3 V +1 12/21/21, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21333

  15. Christian Kuhn commented on patch set 3 CR -1 12/21/21, 09:58

    minor nitpick of probably a rebase issue with a patch from yesterday ... otherwise i'd be fine with this.

    composer.json:4

    please use 'database records' over 'database-records' again ... i just changed that yesterday ... also in the files below. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/72742
  16. Susi Moog commented on patch set 4 12/21/21, 10:05

    Published edit on patch set 3.
  17. Susi Moog commented on patch set 4 12/21/21, 10:06

    composer.json:4 Reply

    will do.
  18. Christian Kuhn updated the commit message in patch set 5 12/21/21, 10:16

  19. Christian Kuhn voted on patch set 5 V +1 CR +1 12/21/21, 10:16

  20. core-ci voted on patch set 4 V +1 12/21/21, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21339

  21. core-ci voted on patch set 5 V +1 12/21/21, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21341

  22. Susi Moog voted on patch set 5 V +1 CR +1 12/21/21, 11:02

  23. Benni Mack voted on patch set 5 V +2 CR +2 12/21/21, 11:06

  24. Christian Kuhn voted on patch set 5 V +2 CR +2 12/21/21, 11:15

  25. Christian Kuhn merged patch set 6 12/21/21, 11:15