Review main Merged Breaking

72498[!!!][TASK] Remove extbase Annotation/Inject

Christian Kuhn CR +2 V +2 Normal +1 −234 updated 12/04/21, 15:14

Commit message

This is not only deprecated but also obsolete with
the removal of extbase ObjectManager object management.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 9

Review log 912

  1. Christian Kuhn uploaded patch set 1 12/03/21, 20:25

  2. Christian Kuhn updated the commit message in patch set 2 12/03/21, 20:26

  3. core-ci voted on patch set 1 V +1 12/03/21, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20534

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 12/03/21, 20:40

  5. core-ci voted on patch set 2 V +1 12/03/21, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20535

  6. Nikita Hovratov commented on patch set 2 12/04/21, 10:02

    One ] too much.
  7. Stefan Bürk updated the commit message in patch set 3 12/04/21, 11:13

  8. Stefan Bürk commented on patch set 3 V +1 CR +1 12/04/21, 11:15

    Reply

    Correct. Done.
  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 12/04/21, 11:16

  10. core-ci voted on patch set 3 V +1 12/04/21, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20554

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 12/04/21, 15:14

  12. Andreas Kienast merged patch set 4 12/04/21, 15:14