Review main Merged

72499[TASK] Avoid testing-framework InternalResponse

Christian Kuhn CR +2 V +2 Easy +12 −15 updated 12/03/21, 23:38

Commit message

The class has been removed as being useless
in testing-framework. A couple of type hints
are adapted.

composer req --dev typo3/testing-framework:dev-main

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Christian Kuhn uploaded patch set 1 12/03/21, 22:56

  2. Christian Kuhn uploaded patch set 2 12/03/21, 23:01

  3. core-ci voted on patch set 1 V +1 12/03/21, 23:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20536

  4. core-ci voted on patch set 2 V +1 12/03/21, 23:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20537

  5. Christian Kuhn uploaded patch set 3 12/03/21, 23:22

  6. core-ci voted on patch set 3 V +1 12/03/21, 23:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20538

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 12/03/21, 23:36

  8. Christian Kuhn commented on patch set 3 V +2 CR +2 12/03/21, 23:37

    Will merge that due to a combined TF patch which would otherwise make nightly red.
  9. Christian Kuhn merged patch set 4 12/03/21, 23:38