Review main Merged Breaking

72501[!!!][TASK] Remove GeneralUtility::minifyJavaScript

Nikita Hovratov CR +2 V +2 Easy +2 −28 updated 12/04/21, 13:08

Commit message

This method was misplaced due to legacy reasons.
The hook is called in ResourceCompressor and this
method is therefore not needed anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 45

  1. Nikita Hovratov uploaded patch set 1 12/04/21, 10:24

  2. core-ci voted on patch set 1 V +1 12/04/21, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20548

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 12/04/21, 11:26

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 12/04/21, 13:08

  5. Christian Kuhn merged patch set 2 12/04/21, 13:08