Review main Merged

72505[TASK] Extract pure mm scenario from ext:irre_tutorial

Anja Leichsenring CR +2 V +2 Expert +755 −702 updated 12/05/21, 17:27

Commit message

The scenario provided by tables tx_irretutorial_mnmmasym_* gets
its own test extension and gets loaded where needed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1217

  1. Anja Leichsenring uploaded patch set 1 12/04/21, 11:58

  2. core-ci voted on patch set 1 V -1 12/04/21, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20555

  3. Stefan Bürk commented on patch set 1 CR -1 12/05/21, 03:54

    Missing types in expected xml * XmlExports/irre-records.xml * XmlImports/irre-records.xml Would have failed for sqlite too, but only 8.1 which is not tested in pre-merge ci. nightly would have found that too. On it to add missing field types.
  4. Stefan Bürk uploaded patch set 2 12/05/21, 04:09

  5. core-ci voted on patch set 2 V +1 12/05/21, 04:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20597

  6. Stefan Bürk commented on patch set 2 12/05/21, 04:24

    pre-merge green, will run nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/20598
  7. Stefan Bürk wrote 12/05/21, 04:24

    Removed reviewer Stefan Bürk.
  8. core-ci commented on patch set 2 12/05/21, 04:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20598

  9. Christian Kuhn commented on patch set 2 12/05/21, 13:04

    irre_tutorial.xml:515

    imho those shouldn't be gone.
  10. Anja Leichsenring uploaded patch set 3 12/05/21, 13:35

  11. Anja Leichsenring commented on patch set 3 12/05/21, 13:36

    irre_tutorial.xml:515 Reply

    Done
  12. core-ci voted on patch set 3 V +1 12/05/21, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20601

  13. core-ci commented on patch set 3 12/05/21, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20604

  14. Christian Kuhn voted on patch set 3 V +1 CR +1 12/05/21, 16:48

  15. Stefan Bürk voted on patch set 3 V +1 CR +1 12/05/21, 16:49

  16. Christian Kuhn voted on patch set 3 V +2 CR +2 12/05/21, 17:27

  17. Christian Kuhn merged patch set 4 12/05/21, 17:27