Review main Merged

72506[TASK] Avoid runtime overriding GLOBALS in functional tests

Christian Kuhn CR +2 V +2 Hard +174 −497 updated 12/04/21, 14:50

Commit message

The InternalResponseContext class of the testing-framework
provides method withGlobalSettings() which can be used to
set arbitrary globals when executing a frontend sub request.

It is used in various tests to set some TYPO3_CONF_VARS.

The testing-framework already provides class property
$configurationToUseInTestInstance to set TYPO3_CONF_VARS
on a per test-case level.

The patch migrates tests towards this property and
avoids using an AdditionalConfiguration fixture file
that is also used to set some TYPO3_CONF_VARS.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 30

Show 10 more files

Review log 47

  1. Christian Kuhn uploaded patch set 1 12/04/21, 12:43

  2. core-ci voted on patch set 1 V +1 12/04/21, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20556

  3. Stefan Bürk commented on patch set 1 V +1 CR +1 12/04/21, 13:10

    Nice. Getting cleaner, step by step.
  4. core-ci voted on patch set 1 V -1 12/04/21, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20558

  5. core-ci voted on patch set 1 V +1 12/04/21, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20558

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 12/04/21, 14:50

  7. Andreas Kienast merged patch set 2 12/04/21, 14:50