72506[TASK] Avoid runtime overriding GLOBALS in functional tests
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 30
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+2 −4
- typo3/sysext/core/Tests/Functional/DataHandling/AbstractDataHandlerActionTestCase.php+8 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/AdditionalConfiguration.phpdeleted+0 −15
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+0 −9
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+0 −1
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+10 −31
- typo3/sysext/fluid_styled_content/Tests/FunctionalDeprecated/Rendering/SecureHtmlRenderingTest.php+10 −31
- typo3/sysext/frontend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.php+2 −6
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+0 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+8 −5
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+8 −5
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/AbstractEnhancerLinkGeneratorTestCase.php+2 −17
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/DefaultExtbaseControllerTest.php+2 −4
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/LocaleModifierTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/PersistedAliasMapperTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/PersistedPatternMapperTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/StaticRangeMapperTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/StaticValueMapperTest.php+1 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/AbstractEnhancerSiteRequestTest.php+2 −15
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PageTypeDecoratorTest.php+1 −1
Show 10 more files
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/RouteTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/AbstractLocalizedPagesTestCase.php+4 −24
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+20 −21
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php+1 −13
- typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php+3 −23
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+20 −72
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+10 −31
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+43 −98
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+1 −14
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+11 −40
Review log 47
-
Christian Kuhn uploaded patch set 1 12/04/21, 12:43
-
core-ci voted on patch set 1 V +1 12/04/21, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20556
-
Stefan Bürk commented on patch set 1 V +1 CR +1 12/04/21, 13:10
Nice. Getting cleaner, step by step. -
core-ci voted on patch set 1 V -1 12/04/21, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20558
-
core-ci voted on patch set 1 V +1 12/04/21, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20558
-
Andreas Kienast voted on patch set 1 V +2 CR +2 12/04/21, 14:50
-
Andreas Kienast merged patch set 2 12/04/21, 14:50