Review main Merged

72507[DOCS] Update EXT:form manual, always use FluidEmail

Lina Wolf CR +2 V +2 Normal +22 −75 updated 12/04/21, 15:08

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Lina Wolf uploaded patch set 1 12/04/21, 12:53

  2. Christian Kuhn commented on patch set 1 CR -1 12/04/21, 13:01

    Index.rst:2112

    I'm -1 on having "option has been removed" docs in our extension manuals: This part should be removed if it's gone. We do that in core code, too. There is no point in keeping it. A patch in v11 to point out that the option is deprecated and will be removed in v12 is a much better solution than carrying "this is gone" in v12.
  3. core-ci voted on patch set 1 V +1 12/04/21, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20557

  4. Lina Wolf uploaded patch set 2 12/04/21, 13:24

  5. Lina Wolf commented on patch set 2 12/04/21, 13:26

    Index.rst:2112 Reply

    Ok, removed it completely.
  6. core-ci voted on patch set 2 V +1 12/04/21, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20560

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 12/04/21, 13:48

  8. Andreas Kienast commented on patch set 3 12/04/21, 14:41

    Published edit on patch set 2.
  9. Andreas Kienast voted on patch set 3 V +1 CR +1 12/04/21, 14:41

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 12/04/21, 14:41

  11. Andreas Kienast voted on patch set 3 V +2 CR +2 12/04/21, 14:51

  12. core-ci voted on patch set 3 V +1 12/04/21, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20563

  13. Andreas Kienast merged patch set 4 12/04/21, 15:08