Review 11.5 Merged

72509[TASK] Avoid runtime overriding GLOBALS in functional tests

Christian Kuhn CR +2 V +2 Hard +174 −497 updated 12/04/21, 16:03

Commit message

The InternalResponseContext class of the testing-framework
provides method withGlobalSettings() which can be used to
set arbitrary globals when executing a frontend sub request.

It is used in various tests to set some TYPO3_CONF_VARS.

The testing-framework already provides class property
$configurationToUseInTestInstance to set TYPO3_CONF_VARS
on a per test-case level.

The patch migrates tests towards this property and
avoids using an AdditionalConfiguration fixture file
that is also used to set some TYPO3_CONF_VARS.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 30

Show 10 more files

Review log 34

  1. Christian Kuhn uploaded patch set 1 12/04/21, 15:49

  2. core-ci voted on patch set 1 V +1 12/04/21, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20571

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 12/04/21, 16:02

  4. Christian Kuhn merged patch set 2 12/04/21, 16:03