Review main Merged Breaking

72512[!!!][TASK] Remove deprecated extbase request related code

Christian Kuhn CR +2 V +2 Normal +8 −118 updated 12/04/21, 21:01

Commit message

* TYPO3\CMS\Extbase\Mvc\Request->getBaseUri()
* TYPO3\CMS\Extbase\Mvc\Request->getRequestUri()
* TYPO3\CMS\Extbase\Mvc\Exception\InvalidRequestMethodException
* TYPO3\CMS\Extbase\Mvc\Web\ReferringRequest

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 5

Files 6

Review log 68

  1. Christian Kuhn uploaded patch set 1 12/04/21, 18:37

  2. core-ci voted on patch set 1 V -1 12/04/21, 18:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20574

  3. Christian Kuhn uploaded patch set 2 12/04/21, 18:45

  4. core-ci voted on patch set 2 V +1 12/04/21, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20575

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/04/21, 20:50

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 12/04/21, 20:54

  7. Benni Mack voted on patch set 2 V +2 CR +2 12/04/21, 21:01

  8. Benni Mack merged patch set 3 12/04/21, 21:01