Review main Merged Breaking

72518[!!!][TASK] Remove USER cObj property set in ContentObjectRenderer

Stefan Bürk CR +2 V +2 Easy +5 −27 updated 12/06/21, 08:37

Commit message

Setting public class property cObj for USER and USER_INT
type frontend plugins has been deprecated in #94956, thus
calling 'setContentObjectRenderer' method if it exists.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 810

  1. Stefan Bürk uploaded patch set 1 12/05/21, 13:47

  2. core-ci voted on patch set 1 V +1 12/05/21, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20602

  3. Oliver Klee commented on patch set 1 12/05/21, 15:15

    GifBuilder.php:100

    We need to either remove this annotation (which would be what I prefer) or change it to ContentObjectRenderer|null to match the native type declaration.
  4. Stefan Bürk uploaded patch set 2 12/05/21, 18:14

  5. Stefan Bürk commented on patch set 2 12/05/21, 18:15

    GifBuilder.php:100 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/05/21, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20614

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 12/05/21, 20:10

  8. Oliver Klee wrote 12/05/21, 23:23

    Removed cc Oliver Klee.
  9. Benni Mack voted on patch set 2 V +2 CR +2 12/06/21, 08:37

  10. Benni Mack merged patch set 3 12/06/21, 08:37