72519[TASK] Cover checkbox TCA option eval with tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/CheckboxRecordsEval.csvnew+15 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/CheckboxValidationTest.phpnew+166 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/Overrides/tt_content.php+13 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/ext_tables.sql+2 −1
Review log 1418
-
Nikita Hovratov uploaded patch set 1 12/05/21, 19:49
-
core-ci voted on patch set 1 V -1 12/05/21, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20615
-
Nikita Hovratov uploaded patch set 2 12/05/21, 20:02
-
core-ci voted on patch set 2 V +1 12/05/21, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20616
-
Oliver Klee commented on patch set 2 12/05/21, 23:23
Nikita, I loving having these additional tests! -
Nikita Hovratov commented on patch set 2 12/06/21, 16:36
Reply
Thanks! There are more to come :) -
Nikita Hovratov uploaded patch set 3 12/06/21, 17:07
-
Nikita Hovratov uploaded patch set 4 12/06/21, 17:09
-
Christian Kuhn voted on patch set 4 CR +1 12/06/21, 17:10
-
core-ci voted on patch set 4 V -1 12/06/21, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20641
-
Christian Kuhn uploaded patch set 5 12/06/21, 17:19
-
Christian Kuhn voted on patch set 5 CR +1 12/06/21, 17:20
-
core-ci voted on patch set 5 V +1 12/06/21, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20642
-
Christian Kuhn voted on patch set 5 V +1 12/06/21, 17:47
-
Wouter Wolters voted on patch set 5 CR +1 12/06/21, 18:10
-
Stefan Bürk commented on patch set 5 V +1 CR +1 12/06/21, 19:38
Nice, thanks for these tests Nikita. -
Christian Kuhn voted on patch set 5 V +2 CR +2 12/06/21, 19:38
-
Christian Kuhn merged patch set 6 12/06/21, 19:38