Review main Merged

72519[TASK] Cover checkbox TCA option eval with tests

Nikita Hovratov CR +2 V +2 Normal +197 −2 updated 12/06/21, 19:38

Commit message

There are two validation rules specific for TCA
type=checkbox:

- maximumRecordsChecked
- maximumRecordsCheckedInPid

These can be set to ensure only a limited amount of
specific checkboxes have been checked system-wide.

They are now covered with tests for live and
workspace context.

Note: Records with another language *do* count to
the total amount. This is probably not a desired
behaviour.

Second note: Values of checkboxes with multiple
items are treated as unique combinations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1418

  1. Nikita Hovratov uploaded patch set 1 12/05/21, 19:49

  2. core-ci voted on patch set 1 V -1 12/05/21, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20615

  3. Nikita Hovratov uploaded patch set 2 12/05/21, 20:02

  4. core-ci voted on patch set 2 V +1 12/05/21, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20616

  5. Oliver Klee commented on patch set 2 12/05/21, 23:23

    Nikita, I loving having these additional tests!
  6. Nikita Hovratov commented on patch set 2 12/06/21, 16:36

    Reply

    Thanks! There are more to come :)
  7. Nikita Hovratov uploaded patch set 3 12/06/21, 17:07

  8. Nikita Hovratov uploaded patch set 4 12/06/21, 17:09

  9. Christian Kuhn voted on patch set 4 CR +1 12/06/21, 17:10

  10. core-ci voted on patch set 4 V -1 12/06/21, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20641

  11. Christian Kuhn uploaded patch set 5 12/06/21, 17:19

  12. Christian Kuhn voted on patch set 5 CR +1 12/06/21, 17:20

  13. core-ci voted on patch set 5 V +1 12/06/21, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20642

  14. Christian Kuhn voted on patch set 5 V +1 12/06/21, 17:47

  15. Wouter Wolters voted on patch set 5 CR +1 12/06/21, 18:10

  16. Stefan Bürk commented on patch set 5 V +1 CR +1 12/06/21, 19:38

    Nice, thanks for these tests Nikita.
  17. Christian Kuhn voted on patch set 5 V +2 CR +2 12/06/21, 19:38

  18. Christian Kuhn merged patch set 6 12/06/21, 19:38