Review main Merged Breaking

72525[!!!][TASK] Remove FormEngine.requestConfirmationOnFieldChange()

Oli Bartsch CR +2 V +2 Easy +4 −8 updated 12/06/21, 18:41

Commit message

The former FormEngine "requestUpdate" functionality
was replaced by a new web component. Therefore, the
old approach is now removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Oli Bartsch uploaded patch set 1 12/06/21, 15:40

  2. core-ci voted on patch set 1 V +1 12/06/21, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20634

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 12/06/21, 16:32

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 12/06/21, 16:36

  5. Oli Bartsch voted on patch set 1 V -1 12/06/21, 16:41

  6. Oli Bartsch uploaded patch set 2 12/06/21, 16:45

  7. core-ci voted on patch set 2 V +1 12/06/21, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20637

  8. Benni Mack voted on patch set 2 V +1 CR +1 12/06/21, 17:02

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 12/06/21, 17:23

  10. Wouter Wolters voted on patch set 2 V +1 CR +1 12/06/21, 18:06

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 12/06/21, 18:41

  12. Andreas Kienast merged patch set 3 12/06/21, 18:41