Review main Merged Breaking

72527[!!!][TASK] Remove jQuery promise polyfill

Andreas Kienast CR +2 V +2 Normal +79 −95 updated 12/10/21, 12:52

Commit message

With #89738, a polyfill for jQuery promises was introduced to ease the
migration to the introduced AjaxRequest API, included with TYPO3 v10.
After two major versions, this polyfill may be removed.

Some remaining occurrences are adjusted as well.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 1318

  1. Andreas Kienast uploaded patch set 1 12/06/21, 16:57

  2. Benni Mack commented on patch set 1 CR -1 12/06/21, 17:01

    Maybe build again, you're adding removed JS files...
  3. core-ci voted on patch set 1 V -1 12/06/21, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20638

  4. Andreas Kienast uploaded patch set 2 12/06/21, 18:02

  5. Andreas Kienast uploaded patch set 3 12/06/21, 18:04

  6. Wouter Wolters commented on patch set 3 12/06/21, 18:07

    Breaking-96263-RemoveJQueryPromiseSupportForAJAXRequests.rst:21

    will trigger
  7. Andreas Kienast uploaded patch set 4 12/06/21, 18:17

  8. core-ci voted on patch set 2 V -1 12/06/21, 18:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20643

  9. Andreas Kienast uploaded patch set 5 12/06/21, 18:18

  10. core-ci voted on patch set 3 V -1 12/06/21, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20644

  11. core-ci voted on patch set 4 V +1 12/06/21, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20645

  12. core-ci voted on patch set 5 V +1 12/06/21, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20646

  13. Benni Mack voted on patch set 5 V +1 CR +1 12/07/21, 07:46

  14. Wouter Wolters voted on patch set 5 CR +1 12/07/21, 08:01

  15. Christian Kuhn commented on patch set 5 V +1 CR +1 12/07/21, 11:18

    Breaking-96263-RemoveJQueryPromiseSupportForAJAXRequests.rst:21 Reply

    Done
  16. Benjamin Franzke voted on patch set 5 V +2 CR +2 12/07/21, 12:34

  17. Benjamin Franzke merged patch set 6 12/07/21, 12:34

  18. Benjamin Franzke commented on patch set 6 12/10/21, 12:52

    Caused a regression in EXT:form. BUGFIX is here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72618