Review main Merged

72529[TASK] Avoid static DatabaseSnapshot setup in functional tests

Christian Kuhn CR +2 V +2 Normal +4 −204 updated 12/06/21, 21:16

Commit message

The testing-framework simplified database snapshotting.
Calling static initializeDatabaseSnapshot() and
tearDownAfterClass() are no longer needed.

composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1

Issues 1

Files 18

Review log 1114

  1. Christian Kuhn uploaded patch set 1 12/06/21, 19:12

  2. Christian Kuhn updated the commit message in patch set 2 12/06/21, 19:13

  3. core-ci voted on patch set 2 V +1 12/06/21, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20649

  4. core-ci voted on patch set 1 V +1 12/06/21, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20648

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 12/06/21, 20:11

  6. Stefan Bürk commented on patch set 2 12/06/21, 20:12

    Great. Next test simplification. Thanks for it !
  7. Stefan Bürk voted on patch set 2 V +1 CR +1 12/06/21, 20:12

  8. Tymoteusz Motylewski commented on patch set 2 12/06/21, 20:28

    databasesnapshot
  9. Christian Kuhn updated the commit message in patch set 3 12/06/21, 20:51

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 12/06/21, 20:51

  11. Christian Kuhn commented on patch set 3 12/06/21, 20:52

    Reply

    Done
  12. Christian Kuhn merged patch set 4 12/06/21, 20:52

  13. core-ci voted on patch set 3 V +1 12/06/21, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20661

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 12/06/21, 21:16