Review main Merged Breaking

72535[!!!][TASK] Force exception handlers to implement setConfiguration()

Oli Bartsch CR +2 V +2 Easy +4 −13 updated 12/07/21, 09:57

Commit message

To enable DI in exception handler classes,
the TypoScript configuration is no longer
passed as constructor argument, but via
the `setConfiguration()` method.

Therefore, the presence of this  method is now
enforced by the ExceptionHandlerInterface.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Oli Bartsch uploaded patch set 1 12/06/21, 23:43

  2. Oli Bartsch rebased onto patch set 2 12/07/21, 08:21

  3. core-ci voted on patch set 2 V +1 12/07/21, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20707

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 12/07/21, 09:08

  5. Benni Mack voted on patch set 2 V +2 CR +2 12/07/21, 09:57

  6. Benni Mack merged patch set 3 12/07/21, 09:57