72537[BUGFIX] switch to ReflectionObject and ReflectionProperty to detect the object properties
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1119
-
Witali Rott uploaded patch set 1 12/07/21, 02:22
-
core-ci voted on patch set 1 V -1 12/07/21, 02:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20705
-
Stefan Bürk commented on patch set 1 12/07/21, 05:31
https://review.typo3.org/c/Packages/TYPO3.CMS/+/72005 also claims to fix the issue. And your other patch. -
core-ci commented on patch set 1 12/07/21, 05:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20705
-
core-ci commented on patch set 1 12/07/21, 05:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20705
-
Benni Mack updated the commit message in patch set 2
V -105/03/23, 09:04 -
core-ci voted on patch set 2 V -1 05/03/23, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41375
-
Oliver Klee updated the commit message in patch set 3
V -105/03/23, 09:09 -
core-ci voted on patch set 3 V -1 05/03/23, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41378
-
Benni Mack updated the commit message in patch set 4
V -105/03/23, 09:13 -
core-ci voted on patch set 4 V -1 05/03/23, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41379
-
Oliver Hader rebased onto patch set 5
V -105/03/23, 11:54 -
JAKOTA Design Group GmbH commented on patch set 5 05/03/23, 12:09
AbstractDomainObject.php:150I believe this could be shortened to just one loop -
JAKOTA Design Group GmbH uploaded patch set 6 05/03/23, 12:11
-
JAKOTA Design Group GmbH commented on patch set 6 05/03/23, 12:12
AbstractDomainObject.php:150ReplyDone -
core-ci voted on patch set 5 V -1 05/03/23, 12:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41525
-
core-ci voted on patch set 6 V -1 05/03/23, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41526
-
Benni Mack commented on patch set 6 07/06/23, 17:38
is this now covered with https://review.typo3.org/c/Packages/TYPO3.CMS/+/72005 or still present? Can we cover this with a test? -
Benni Mack abandoned the change 07/06/23, 17:38
will abandon this change for now as the issue is resolved.