Review main Merged Breaking

72538[!!!][TASK] Remove LanguageService container entry

Oli Bartsch CR +2 V +2 Normal +14 −48 updated 12/07/21, 11:00

Commit message

In favour of the LanguageServiceFactory, the container
entry as well as the corresponding factory methods
in LanguageService are now removed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1015

  1. Oli Bartsch uploaded patch set 1 12/07/21, 09:49

  2. Oli Bartsch updated the commit message in patch set 2 12/07/21, 09:55

  3. Benjamin Franzke commented on patch set 2 CR -1 12/07/21, 09:59

    LanguageService.php:86

    I will take a look how to avoid this.
  4. core-ci voted on patch set 1 V +1 12/07/21, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20708

  5. Benjamin Franzke uploaded patch set 3 12/07/21, 10:04

  6. core-ci voted on patch set 3 V -1 12/07/21, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20710

  7. Oli Bartsch uploaded patch set 4 12/07/21, 10:08

  8. Oli Bartsch commented on patch set 4 12/07/21, 10:08

    LanguageService.php:86 Reply

    Ack
  9. core-ci voted on patch set 2 V +1 12/07/21, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20709

  10. core-ci voted on patch set 4 V +1 12/07/21, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20711

  11. Benjamin Franzke uploaded patch set 5 12/07/21, 10:27

  12. core-ci voted on patch set 5 V +1 12/07/21, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20713

  13. Stefan Bürk voted on patch set 5 V +1 CR +1 12/07/21, 10:48

  14. Oli Bartsch voted on patch set 5 V +2 CR +2 12/07/21, 11:00

  15. Oli Bartsch merged patch set 6 12/07/21, 11:00