Review main Merged

72539[BUGFIX] Exclude colorpicker from overflow hidden

Nikita Hovratov CR +2 V +2 Easy +6 −3 updated 12/07/21, 12:53

Commit message

In order to fix a visual bug of overflowing select
fields inside palettes, the css attribute overflow:
hidden has been added to one of the wrapping fields
of form wizards.

This caused our colorpicker to be invisible for the
user, as it is directly appended after the input
field inside the DOM (Unlike to the behaviour of
flatpickr, which is added to the end of the body
tag).

A new modifier class
"form-wizards-element--overflow-visible" has been
added to disable the overflow hidden rule for
specific fields.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Nikita Hovratov uploaded patch set 1 12/07/21, 10:16

  2. core-ci voted on patch set 1 V +1 12/07/21, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20712

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 12/07/21, 11:15

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/07/21, 12:24

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/07/21, 12:53

  6. Benjamin Franzke merged patch set 2 12/07/21, 12:53