72541[!!!][TASK] Remove non-factory init of RenderingContext
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1215
-
Christian Kuhn uploaded patch set 1 12/07/21, 11:58
-
core-ci voted on patch set 1 V +1 12/07/21, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20718
-
Christian Kuhn updated the commit message in patch set 2 12/07/21, 12:15
-
Benjamin Franzke commented on patch set 2 CR -1 12/07/21, 12:21
Please see https://review.typo3.org/c/Packages/TYPO3.CMS/+/72538 for an example how we should handle this (via exclude: and mentioning in .rst) -
Benjamin Franzke uploaded patch set 3 12/07/21, 12:25
-
core-ci voted on patch set 2 V +1 12/07/21, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20719
-
core-ci voted on patch set 3 V +1 12/07/21, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20721
-
Christian Kuhn commented on patch set 3 12/07/21, 13:13
Ah good point. Thx Benjamin. -
Stefan Bürk voted on patch set 3 V +1 CR +1 12/07/21, 13:41
-
Christian Kuhn voted on patch set 3 V +2 CR +2 12/07/21, 13:44
-
Christian Kuhn merged patch set 4 12/07/21, 13:44
-
Oliver Hader commented on patch set 4 09/07/22, 08:24
Services.yaml:12This probably should have been just `RenderingContext` not `RenderingContextFactory`? -
Oliver Hader commented on patch set 4 09/07/22, 08:31
Services.yaml:12ReplyProbably this will change with symfony/di v6.2, see https://github.com/symfony/dependency-injection/blame/6fe3a5200f4cfa719d8988280909cc24e3801759/Compiler/AbstractRecursivePass.php#L75-L77 -
Susi Moog commented on patch set 4 09/15/22, 12:18
Services.yaml:12Reply -
Christian Kuhn commented on patch set 4 09/21/22, 12:44
Services.yaml:12ReplyDone