Review main Merged Breaking

72542[!!!][TASK] Remove \Serializable from CollectionInterface

Christian Kuhn CR +2 V +2 Easy +2 −28 updated 12/07/21, 15:09

Commit message

Implementing \Serializable has been a b/w compat
layer for v11 and is superseded by __serialize()
and __unserialize(). The interface no longer
extends \Serializable and implementation is removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/07/21, 12:32

  2. core-ci voted on patch set 1 V +1 12/07/21, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20722

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 12/07/21, 12:45

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 12/07/21, 15:07

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/07/21, 15:09

  6. Christian Kuhn merged patch set 2 12/07/21, 15:09