Review main Merged Breaking

72543[!!!][TASK] Remove TypoScriptFrontendController container entry

Benjamin Franzke CR +2 V +2 Easy +5 −11 updated 12/07/21, 14:07

Commit message

TypoScriptFrontendController is stateful and breaks subrequests
when injected. It must be therefore be retrieved rom the request
attribute frontend.controller.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Benjamin Franzke uploaded patch set 1 12/07/21, 12:43

  2. core-ci voted on patch set 1 V +1 12/07/21, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20723

  3. Christian Kuhn rebased onto patch set 2 12/07/21, 13:45

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 12/07/21, 13:47

  5. core-ci voted on patch set 2 V +1 12/07/21, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20727

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 12/07/21, 14:04

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 12/07/21, 14:07

  8. Oli Bartsch merged patch set 3 12/07/21, 14:07