Review main Merged

7255[BUGFIX] noTrimWrap = | || won't work inside a menu

Jochen Rau CR +2 V +2 Easy +1 −1 updated 06/22/15, 01:20

Commit message

The issue is caused by the implementation of optionSplit. This patch
solves this issue by checking for noTrimWrap.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1

Files 1

Review log 23

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
    affects which Releases?

    class.t3lib_tstemplate.php:1033

    should we maybe use strpos for finding and check for !== FALSE then? Also the php-manual suggests that strpos might have slightly less overhead. But for sure this is nothing important. But imho we should check for !== FALSE to be "clean".
  2. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    (1 inline comment)
  3. Stefan Neufeind commented on patch set 2 05/27/13, 17:19

    hand-rebased, added link to forge-issue, added releases-line (was originally filed against 4.3 so I assume 4.5 is first)
  4. Stefan Neufeind uploaded patch set 2 05/27/13, 17:19

  5. Mattias Nilsson commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  8. Wouter Wolters uploaded patch set 3 05/28/13, 19:41

  9. Mr. Jenkins commented on patch set 3 05/28/13, 19:42

  10. Stefan Neufeind voted on patch set 3 CR +1 08/05/13, 20:33

  11. Benni Mack rebased onto patch set 3 09/09/14, 10:37

  12. Benni Mack updated the commit message in patch set 5 09/09/14, 10:37

  13. Stefan Neufeind updated the commit message in patch set 6 09/20/14, 18:55

  14. Stefan Neufeind commented on patch set 6 09/20/14, 18:55

    I expect only 6.2/master.
  15. Stefan Neufeind commented on patch set 6 09/20/14, 18:58

    Forge says this is already "resolved" in newer releases? @Jochen: Could you please have a closer look? I'm not sure how the fix mentioned there relates to your change here.
  16. Mathias Schreiber commented on patch set 6 CR +1 V +1 12/12/14, 21:02

    Even though the issue on forge was closed, the problem this exists in current master (CMS7.1-dev). The TS from the ticket still applies and this patch fixes the issue
  17. Christian Kuhn updated the commit message in patch set 7 12/12/14, 21:09

  18. Benni Mack voted on patch set 7 CR +1 12/12/14, 21:38

  19. Mathias Schreiber voted on patch set 7 CR +1 V +1 12/13/14, 09:27

  20. Benni Mack voted on patch set 7 CR +2 V +2 12/13/14, 09:52

  21. Benni Mack merged patch set 7 12/13/14, 09:52

  22. Benni Mack commented on patch set 8 12/13/14, 09:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit a3318eb66c02be3a487aa5001f7965ac26c3c6b6
  23. Stefan Neufeind commented on patch set 8 06/22/15, 01:20

    imho a possible regression caused by this patch: https://forge.typo3.org/issues/67669 I've encountered the changed behaviour after upgrading a site from 4.5 to 6.2. Reverting the patch restores the previous (working) behaviour with optionSplit and noTrimWrap.