7255[BUGFIX] noTrimWrap = | || won't work inside a menu
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Mathias Schreiber +1
-
Verified V +2
- Benni Mack +2
- Mathias Schreiber +1
Files 1
Review log 23
-
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approveaffects which Releases?class.t3lib_tstemplate.php:1033should we maybe use strpos for finding and check for !== FALSE then? Also the php-manual suggests that strpos might have slightly less overhead. But for sure this is nothing important. But imho we should check for !== FALSE to be "clean". -
Stefan Neufeind commented on patch set 1 05/27/13, 17:19
(1 inline comment) -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
hand-rebased, added link to forge-issue, added releases-line (was originally filed against 4.3 so I assume 4.5 is first) -
Stefan Neufeind uploaded patch set 2 05/27/13, 17:19
-
Mattias Nilsson commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2743/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6854/ : SUCCESS -
Wouter Wolters uploaded patch set 3 05/28/13, 19:41
-
Mr. Jenkins commented on patch set 3 05/28/13, 19:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8918/ : SUCCESS -
Stefan Neufeind voted on patch set 3 CR +1 08/05/13, 20:33
-
Benni Mack rebased onto patch set 3 09/09/14, 10:37
-
Benni Mack updated the commit message in patch set 5 09/09/14, 10:37
-
Stefan Neufeind updated the commit message in patch set 6 09/20/14, 18:55
-
Stefan Neufeind commented on patch set 6 09/20/14, 18:55
I expect only 6.2/master. -
Stefan Neufeind commented on patch set 6 09/20/14, 18:58
Forge says this is already "resolved" in newer releases? @Jochen: Could you please have a closer look? I'm not sure how the fix mentioned there relates to your change here. -
Mathias Schreiber commented on patch set 6 CR +1 V +1 12/12/14, 21:02
Even though the issue on forge was closed, the problem this exists in current master (CMS7.1-dev). The TS from the ticket still applies and this patch fixes the issue -
Christian Kuhn updated the commit message in patch set 7 12/12/14, 21:09
-
Benni Mack voted on patch set 7 CR +1 12/12/14, 21:38
-
Mathias Schreiber voted on patch set 7 CR +1 V +1 12/13/14, 09:27
-
Benni Mack voted on patch set 7 CR +2 V +2 12/13/14, 09:52
-
Benni Mack merged patch set 7 12/13/14, 09:52
-
Benni Mack commented on patch set 8 12/13/14, 09:52
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit a3318eb66c02be3a487aa5001f7965ac26c3c6b6 -
Stefan Neufeind commented on patch set 8 06/22/15, 01:20
imho a possible regression caused by this patch: https://forge.typo3.org/issues/67669 I've encountered the changed behaviour after upgrading a site from 4.5 to 6.2. Reverting the patch restores the previous (working) behaviour with optionSplit and noTrimWrap.