Review main Merged

72551[BUGFIX] Add createSchemaManager to DBAL Connection

Benni Mack CR +2 V +2 Normal +37 −23 updated 12/08/21, 12:37

Commit message

This change adds the new createSchemaManager() to
our Doctrine DBAL Connection subclass to make it
forward-compatible with Doctrine DBAL 3.x.

createSchemaManager() is introduced with DBAL 3.x and
is replacing getSchemaManager() which will be removed
in Doctrine DBAL 4.

Since this is a very lowlevel change, the method
can be added without most notice for extension authors.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 812

  1. Benni Mack uploaded patch set 1 12/07/21, 22:22

  2. core-ci voted on patch set 1 V -1 12/07/21, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20755

  3. Benni Mack commented on patch set 2 12/08/21, 10:01

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 12/08/21, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20769

  5. Benni Mack updated the commit message in patch set 3 12/08/21, 10:39

  6. Benni Mack uploaded patch set 4 12/08/21, 10:44

  7. core-ci voted on patch set 3 V +1 12/08/21, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20770

  8. core-ci voted on patch set 4 V +1 12/08/21, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20771

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 12/08/21, 12:03

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 12/08/21, 12:37

  11. Benni Mack voted on patch set 4 V +2 CR +2 12/08/21, 12:37

  12. Benni Mack merged patch set 5 12/08/21, 12:37