Review main Merged Breaking

72552[!!!][TASK] Remove route parameter from backend urls

Oli Bartsch CR +2 V +2 Easy +24 −22 updated 12/08/21, 20:04

Commit message

Due to the introduction of URL rewrites
for backend links in #93048, the `route`
parameter got superfluous and is therefore
no longer added to backend urls.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 810

  1. Oli Bartsch uploaded patch set 1 12/07/21, 22:51

  2. core-ci voted on patch set 1 V +1 12/07/21, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20756

  3. Benni Mack commented on patch set 1 12/08/21, 12:37

    EditDocumentController.php:1684

    This ain't good. Use TYPO3_mainDir please.
  4. Oli Bartsch uploaded patch set 2 12/08/21, 12:40

  5. Oli Bartsch commented on patch set 2 12/08/21, 12:41

    EditDocumentController.php:1684 Reply

    Done
  6. core-ci voted on patch set 2 V +1 12/08/21, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20777

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 12/08/21, 17:30

  8. Wouter Wolters voted on patch set 2 CR +1 12/08/21, 19:25

  9. Benni Mack voted on patch set 2 V +2 CR +2 12/08/21, 20:04

  10. Benni Mack merged patch set 3 12/08/21, 20:04