Review main Merged Breaking

72553[!!!][TASK] Remove extbase switchable controller actions

Christian Kuhn CR +2 V +2 Hard +3 −865 updated 12/08/21, 16:04

Commit message

Extbase "switchable controller actions" have been
deprecated with core v10. They are removed now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Alexander Schnitzler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 1114

  1. Christian Kuhn uploaded patch set 1 12/07/21, 23:03

  2. core-ci voted on patch set 1 V -1 12/07/21, 23:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20757

  3. Christian Kuhn uploaded patch set 2 12/07/21, 23:06

  4. core-ci voted on patch set 2 V +1 12/07/21, 23:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20758

  5. Benni Mack voted on patch set 2 V +1 CR +1 12/08/21, 07:39

  6. Benjamin Franzke commented on patch set 2 CR -1 12/08/21, 07:43

    The comment for TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager::overrideConfigurationFromFlexForm still mentiones: > This merges the whole flexForm data, and overrides the controller configuration with possibly configured switchable controller actions. Maybe Alex – as author of the deprecation – should also take a look at this
  7. Christian Kuhn commented on patch set 2 12/08/21, 10:29

    Reply

    ah good catch. looks as if i missed a 'grep' variant to search for ;)
  8. Christian Kuhn uploaded patch set 3 12/08/21, 12:01

  9. core-ci voted on patch set 3 V +1 12/08/21, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20775

  10. Alexander Schnitzler voted on patch set 3 CR +1 12/08/21, 14:03

  11. Benni Mack voted on patch set 3 V +1 CR +1 12/08/21, 15:03

  12. Jochen Roth voted on patch set 3 V +1 CR +1 12/08/21, 16:03

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 12/08/21, 16:04

  14. Christian Kuhn merged patch set 4 12/08/21, 16:04