Review 11.5 Merged

72555[BUGFIX] Add createSchemaManager to DBAL Connection

Christian Kuhn CR +2 V +2 Normal +37 −23 updated 12/08/21, 12:38

Commit message

This change adds the new createSchemaManager() to
our Doctrine DBAL Connection subclass to make it
forward-compatible with Doctrine DBAL 3.x.

createSchemaManager() is introduced with DBAL 3.x and
is replacing getSchemaManager() which will be removed
in Doctrine DBAL 4.

Since this is a very lowlevel change, the method
can be added without most notice for extension authors.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 19

Review log 34

  1. Christian Kuhn uploaded patch set 1 12/08/21, 11:19

  2. core-ci voted on patch set 1 V +1 12/08/21, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20773

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/08/21, 12:38

  4. Benni Mack merged patch set 2 12/08/21, 12:38