Review main Merged

72557[FOLLOWUP] Remove onChange callback from SelectSingleElement

Oli Bartsch CR +2 V +2 Easy +3 −10 updated 12/08/21, 22:44

Commit message

Using onChange callbacks in FormEngine
was removed with #96158. This removes
a left over.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Oli Bartsch uploaded patch set 1 12/08/21, 13:29

  2. Oli Bartsch updated the commit message in patch set 2 12/08/21, 13:29

  3. core-ci voted on patch set 1 V +1 12/08/21, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20781

  4. core-ci voted on patch set 2 V +1 12/08/21, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20782

  5. Oliver Hader commented on patch set 2 12/08/21, 14:03

    SelectSingleElement.ts:21

    We could "enforce" `OnFieldChangeItem[]` here and drop the function callback `Listener`
  6. Oli Bartsch uploaded patch set 3 12/08/21, 17:11

  7. Oli Bartsch commented on patch set 3 12/08/21, 17:12

    SelectSingleElement.ts:21 Reply

    Done
  8. Christian Kuhn voted on patch set 3 V +1 CR +1 12/08/21, 17:15

  9. core-ci voted on patch set 3 V +1 12/08/21, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20802

  10. Wouter Wolters voted on patch set 3 CR +1 12/08/21, 21:16

  11. Benni Mack voted on patch set 3 V +1 CR +1 12/08/21, 21:35

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 12/08/21, 22:39

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 12/08/21, 22:44

  14. Christian Kuhn merged patch set 4 12/08/21, 22:44