72558[!!!][TASK] Disallow DB connection before TCA is loaded
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Classes/Core/BootService.php2+1 −3
- typo3/sysext/core/Classes/Core/Bootstrap.php+0 −4
- typo3/sysext/core/Classes/Error/ErrorHandler.php+2 −2
- typo3/sysext/core/Classes/Log/Writer/DatabaseWriter.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+2 −9
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96291-DisallowDBConnectionBeforeTCAIsLoaded.rstnew+37 −0
Review log 1013
-
Helmut Hummel uploaded patch set 1 12/08/21, 15:49
-
core-ci voted on patch set 1 V +1 12/08/21, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20787
-
Benjamin Franzke commented on patch set 1 CR +1 12/08/21, 16:08
We could also add a Related: line to the deprecating patch (if another revision is needed) -
Benni Mack commented on patch set 1 12/08/21, 17:04
BootService.php:139that's a change of behaviour for the PSR-14 event, right? -
Benjamin Franzke commented on patch set 1 V +1 12/08/21, 17:44
BootService.php:139Replyyea, but only in installtool/cache-warmup context. and it is actually streamlined to the "main" frontend/backend handling. …and therefore described in the commit message. talked with helmut about this before and think this is fine. -
Benni Mack updated the commit message in patch set 2 12/08/21, 20:07
-
Benni Mack commented on patch set 2 V +1 CR +1 12/08/21, 20:07
Reply
Done -
core-ci voted on patch set 2 V +1 12/08/21, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20815
-
Oli Bartsch voted on patch set 2 V +1 CR +1 12/08/21, 20:27
-
Wouter Wolters voted on patch set 2 CR +1 12/08/21, 20:47
-
Benjamin Franzke voted on patch set 2 V +2 CR +2 12/08/21, 21:09
-
Benjamin Franzke merged patch set 3 12/08/21, 21:09
-
core-ci voted on patch set 2 V +1 12/08/21, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20817