Review main Merged Breaking

72558[!!!][TASK] Disallow DB connection before TCA is loaded

Helmut Hummel CR +2 V +2 Normal +43 −19 updated 12/08/21, 21:24

Commit message

Convert the deprecation that was introduced in TYPO3 11 into an exception.

Also remove the now obsolete boot state "done" and make sure
boot state "complete" is always set before ext_tables.php
are loaded. The latter wasn't the case when using BootService,
all other boot types already allowed database and cache manager access
in ext_tables.php files.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1013

  1. Helmut Hummel uploaded patch set 1 12/08/21, 15:49

  2. core-ci voted on patch set 1 V +1 12/08/21, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20787

  3. Benjamin Franzke commented on patch set 1 CR +1 12/08/21, 16:08

    We could also add a Related: line to the deprecating patch (if another revision is needed)
  4. Benni Mack commented on patch set 1 12/08/21, 17:04

    BootService.php:139

    that's a change of behaviour for the PSR-14 event, right?
  5. Benjamin Franzke commented on patch set 1 V +1 12/08/21, 17:44

    BootService.php:139 Reply

    yea, but only in installtool/cache-warmup context. and it is actually streamlined to the "main" frontend/backend handling. …and therefore described in the commit message. talked with helmut about this before and think this is fine.
  6. Benni Mack updated the commit message in patch set 2 12/08/21, 20:07

  7. Benni Mack commented on patch set 2 V +1 CR +1 12/08/21, 20:07

    Reply

    Done
  8. core-ci voted on patch set 2 V +1 12/08/21, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20815

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 12/08/21, 20:27

  10. Wouter Wolters voted on patch set 2 CR +1 12/08/21, 20:47

  11. Benjamin Franzke voted on patch set 2 V +2 CR +2 12/08/21, 21:09

  12. Benjamin Franzke merged patch set 3 12/08/21, 21:09

  13. core-ci voted on patch set 2 V +1 12/08/21, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20817