72559[TASK] Harden ExtbaseRequestParameters
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1216
-
Christian Kuhn uploaded patch set 1 12/08/21, 16:12
-
Christian Kuhn uploaded patch set 2 12/08/21, 16:14
-
core-ci voted on patch set 1 V -1 12/08/21, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20790
-
core-ci voted on patch set 2 V +1 12/08/21, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20791
-
Benni Mack commented on patch set 2 12/08/21, 16:45
Request.php:162should be ?string $controllerName = nullRequest.php:181should be ?string $actionName = null -
Christian Kuhn commented on patch set 2 12/08/21, 17:06
ExtbaseRequestParameters.php:430Replyentire class is @internal - it should only be used indirectly via extbase request object. -
Christian Kuhn uploaded patch set 3 12/08/21, 17:49
-
Christian Kuhn commented on patch set 3 12/08/21, 17:49
Request.php:162ReplyDoneRequest.php:181ReplyDone -
Christian Kuhn uploaded patch set 4 12/08/21, 17:56
-
core-ci voted on patch set 3 V +1 12/08/21, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20804
-
core-ci voted on patch set 4 V +1 12/08/21, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20805
-
Benni Mack voted on patch set 4 V +1 CR +1 12/08/21, 20:06
-
Oli Bartsch commented on patch set 4 CR -1 12/08/21, 20:32
will review now -
Oli Bartsch voted on patch set 4 V +1 CR +1 12/08/21, 20:43
-
Christian Kuhn voted on patch set 4 V +2 CR +2 12/08/21, 20:47
-
Christian Kuhn merged patch set 5 12/08/21, 20:47
ExtbaseRequestParameters.php:430