Review main Merged

72559[TASK] Harden ExtbaseRequestParameters

Christian Kuhn CR +2 V +2 Hard +68 −215 updated 12/08/21, 20:47

Commit message

ExtbaseRequestParameters is the old extbase request,
now a PSR-7 attribute. To continue with refactorings
in related areas, the @internal attribute is now hardened
with proper type hints and return values.
The properties receive some documentation love to finally
have a place where all the different state is documented
including some hopefully meaningful examples.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Christian Kuhn uploaded patch set 1 12/08/21, 16:12

  2. Christian Kuhn uploaded patch set 2 12/08/21, 16:14

  3. core-ci voted on patch set 1 V -1 12/08/21, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20790

  4. core-ci voted on patch set 2 V +1 12/08/21, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20791

  5. Benni Mack commented on patch set 2 12/08/21, 16:45

    ExtbaseRequestParameters.php:430

    do we want to keep the internal information?

    Request.php:162

    should be ?string $controllerName = null

    Request.php:181

    should be ?string $actionName = null
  6. Christian Kuhn commented on patch set 2 12/08/21, 17:06

    ExtbaseRequestParameters.php:430 Reply

    entire class is @internal - it should only be used indirectly via extbase request object.
  7. Christian Kuhn uploaded patch set 3 12/08/21, 17:49

  8. Christian Kuhn commented on patch set 3 12/08/21, 17:49

    Request.php:162 Reply

    Done

    Request.php:181 Reply

    Done
  9. Christian Kuhn uploaded patch set 4 12/08/21, 17:56

  10. core-ci voted on patch set 3 V +1 12/08/21, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20804

  11. core-ci voted on patch set 4 V +1 12/08/21, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20805

  12. Benni Mack voted on patch set 4 V +1 CR +1 12/08/21, 20:06

  13. Oli Bartsch commented on patch set 4 CR -1 12/08/21, 20:32

    will review now
  14. Oli Bartsch voted on patch set 4 V +1 CR +1 12/08/21, 20:43

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 12/08/21, 20:47

  16. Christian Kuhn merged patch set 5 12/08/21, 20:47