Review main Merged

72560[FOLLOWUP] Fix test splitter to respect methods without comment

Jochen Roth CR +2 V +2 Easy +24 −19 updated 12/08/21, 20:41

Commit message

In #96158 ac tests have been adapted to the current state
but accidentially removed the fix for the splitter.

The code for the splitter has been added again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 917

  1. Jochen Roth uploaded patch set 1 12/08/21, 16:54

  2. Christian Kuhn updated the commit message in patch set 2 12/08/21, 17:00

  3. Jochen Roth updated the commit message in patch set 3 12/08/21, 17:08

  4. core-ci voted on patch set 1 V -1 12/08/21, 17:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20793

  5. core-ci voted on patch set 3 V -1 12/08/21, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20801

  6. core-ci voted on patch set 2 V -1 12/08/21, 17:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20797

  7. Christian Kuhn updated the commit message in patch set 4 12/08/21, 17:31

  8. core-ci voted on patch set 4 V -1 12/08/21, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20803

  9. Christian Kuhn uploaded patch set 5 12/08/21, 18:42

  10. Christian Kuhn commented on patch set 5 12/08/21, 18:46

    note i'll have to rush here a bit since that was planned to be inlined in https://review.typo3.org/c/Packages/TYPO3.CMS/+/72554 already and we otherwise end up with red nightly. i'll torture nightly with this and will merge if green.
  11. core-ci voted on patch set 5 V -1 12/08/21, 19:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20807

  12. core-ci voted on patch set 5 V +1 12/08/21, 19:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20806

  13. Christian Kuhn uploaded patch set 6 12/08/21, 19:36

  14. core-ci voted on patch set 6 V +1 12/08/21, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20811

  15. core-ci commented on patch set 6 12/08/21, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20812

  16. Christian Kuhn commented on patch set 6 V +2 CR +2 12/08/21, 20:41

    have to merge this now to prevent broken nightlies ...
  17. Christian Kuhn merged patch set 7 12/08/21, 20:41