Review main Merged Breaking

72561[!!!][TASK] Remove global initialization of DateTimePicker fields

Oli Bartsch CR +2 V +2 Normal +29 −36 updated 12/09/21, 13:17

Commit message

The DateTimePicker does no longer initialize
fields, which define the `t3js-datetimepicker`
class, automatically.

This must be done by passing the corresponding
`HTMLInputElement` to `DateTimePicker.initialize()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Jochen Roth +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 68

  1. Oli Bartsch uploaded patch set 1 12/08/21, 17:03

  2. core-ci voted on patch set 1 V +1 12/08/21, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20799

  3. Benjamin Franzke uploaded patch set 2 12/09/21, 10:33

  4. core-ci voted on patch set 2 V +1 12/09/21, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20849

  5. Wouter Wolters voted on patch set 2 CR +1 12/09/21, 12:38

  6. Jochen Roth voted on patch set 2 V +1 CR +1 12/09/21, 12:38

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 12/09/21, 13:16

  8. Oli Bartsch merged patch set 3 12/09/21, 13:17