Review main Merged

72562[TASK] Clean up unrealistic @todo in QueryInterface

Christian Kuhn CR +2 V +2 Easy +1 −5 updated 12/08/21, 20:43

Commit message

There are two QueryInterface methods marked with @todo
"See if we can get rid of these" for a very long time.
It doesn't look feasible to get rid of QuerySettings
any time soon, the construct will survive for the time
being and may only be tackled when we have a broader
look at the extbase query logic. Remove the todos.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 12/08/21, 19:03

  2. core-ci voted on patch set 1 V +1 12/08/21, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20810

  3. Benni Mack voted on patch set 1 V +1 CR +1 12/08/21, 20:04

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 12/08/21, 20:42

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 12/08/21, 20:43

  6. Christian Kuhn merged patch set 2 12/08/21, 20:43