Review main Merged Breaking

72563[!!!][TASK] Remove AbstractControl::setOnClick for backend user interface

Oli Bartsch CR +2 V +2 Normal +4 −64 updated 12/08/21, 22:46

Commit message

In favour of allowing content-security-policy headers, inline
JavaScript invocation via `AbstractControl::setOnClick` is
now removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 68

  1. Oli Bartsch uploaded patch set 1 12/08/21, 21:17

  2. Wouter Wolters voted on patch set 1 CR +1 12/08/21, 21:18

  3. core-ci voted on patch set 1 V -1 12/08/21, 21:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20819

  4. Oli Bartsch uploaded patch set 2 12/08/21, 21:58

  5. core-ci voted on patch set 2 V +1 12/08/21, 22:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20821

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 12/08/21, 22:37

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 12/08/21, 22:46

  8. Christian Kuhn merged patch set 3 12/08/21, 22:46