Review main Merged

72567[TASK] Remove a set of skipped unit tests

Christian Kuhn CR +2 V +2 Expert +2 −1129 updated 12/09/21, 13:10

Commit message

This patch removes a series of unit tests from the
test sets that are often either skipped or flaky.

* There is little point in testing chmod() / chgrp()
  operations of low-level methods. That's a system thing
  we shouldn't test in detail.
* Some tests have been marked as "i'm mocking too much,
  make me a functional test". Most of these are oooold.
  Don't read it, delete it.
* Some phpunit @requires annotations have been broken
  since introduction and always resulted in "skip test".
  Remove those.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 811

  1. Christian Kuhn uploaded patch set 1 12/08/21, 23:44

  2. Christian Kuhn uploaded patch set 2 12/08/21, 23:45

  3. core-ci voted on patch set 1 V -1 12/08/21, 23:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20830

  4. Christian Kuhn updated the commit message in patch set 3 12/08/21, 23:55

  5. core-ci voted on patch set 2 V +1 12/08/21, 23:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20831

  6. core-ci voted on patch set 3 V +1 12/09/21, 00:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20832

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 12/09/21, 00:13

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 12/09/21, 12:38

  9. Benni Mack voted on patch set 3 V +1 CR +1 12/09/21, 12:52

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 12/09/21, 13:10

  11. Christian Kuhn merged patch set 4 12/09/21, 13:10