Review 11.5 Merged

72570[TASK] Allow composer installers ^4.0

Helmut Hummel CR +2 V +2 Easy +30 −13 updated 12/09/21, 15:35

Commit message

Allow composer installers ^4.0 and also enforce some constraints
that could be violated with the new installers.

1. Do not allow duplicate extension keys

Multiple packages could define the same extension key.
When all extensions are then installed in vendor folder, there won't
be any conflicts on the file system, so an exception is now thrown
to make people aware of this misconfiguration.

2. Throw an exception if extensions of type typo3-cms-extension do
   not define an extension key

Actually this exception is thrown in the installers package, but the
artifact builder must propagate this exception to ensure it
reaches the users.

composer req typo3/cms-composer-installers:"^2.0 || ^3.0 || ^4.0"
composer req typo3/cms-composer-installers:"^2.0 || ^3.0 || ^4.0" \
 --no-update -d typo3/sysext/core/

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Helmut Hummel uploaded patch set 1 12/09/21, 10:27

  2. Helmut Hummel rebased onto patch set 2 12/09/21, 10:27

  3. core-ci voted on patch set 1 V +1 12/09/21, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20847

  4. core-ci voted on patch set 2 V +1 12/09/21, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20848

  5. Simon Gilli voted on patch set 2 V +1 CR +1 12/09/21, 12:14

  6. Benni Mack voted on patch set 2 V +1 CR +1 12/09/21, 12:53

  7. Helmut Hummel voted on patch set 2 V +2 CR +2 12/09/21, 15:34

  8. Helmut Hummel merged patch set 3 12/09/21, 15:35