Review 11.5 Merged

72594[TASK] Remove a set of skipped unit tests

Christian Kuhn CR +2 V +2 Expert +2 −1129 updated 12/09/21, 13:38

Commit message

This patch removes a series of unit tests from the
test sets that are often either skipped or flaky.

* There is little point in testing chmod() / chgrp()
  operations of low-level methods. That's a system thing
  we shouldn't test in detail.
* Some tests have been marked as "i'm mocking too much,
  make me a functional test". Most of these are oooold.
  Don't read it, delete it.
* Some phpunit @requires annotations have been broken
  since introduction and always resulted in "skip test".
  Remove those.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 14

Review log 34

  1. Christian Kuhn uploaded patch set 1 12/09/21, 13:13

  2. core-ci voted on patch set 1 V +1 12/09/21, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20862

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 12/09/21, 13:38

  4. Christian Kuhn merged patch set 2 12/09/21, 13:38