Review main Merged Breaking

72595[!!!][TASK] Remove extbase parameter type resolving via doc blocks

Christian Kuhn CR +2 V +2 Easy +8 −5 updated 12/15/21, 14:57

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1624

  1. Christian Kuhn uploaded patch set 1 12/09/21, 13:59

  2. Benni Mack commented on patch set 2 12/09/21, 14:07

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 12/09/21, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20864

  4. core-ci voted on patch set 2 V -1 12/09/21, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20867

  5. core-ci commented on patch set 2 12/09/21, 18:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20867

  6. Benni Mack rebased onto patch set 3 12/09/21, 22:15

  7. core-ci voted on patch set 3 V -1 12/09/21, 22:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20905

  8. Benni Mack rebased onto patch set 4 12/10/21, 11:48

  9. core-ci voted on patch set 4 V -1 12/10/21, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20932

  10. Christian Kuhn uploaded patch set 5 12/11/21, 10:46

  11. core-ci voted on patch set 5 V -1 12/11/21, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20981

  12. Christian Kuhn uploaded patch set 6 12/11/21, 12:08

  13. core-ci voted on patch set 6 V +1 12/11/21, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20984

  14. Nikita Hovratov commented on patch set 6 12/11/21, 16:59

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:379

    We should emphasize, that this does only apply to method parameters for defined validators and DI related methods (constructor, injectFoo). All other parameters without special meaning still work with the doc block fallback (as you wrote in the comment down below).
  15. Christian Kuhn commented on patch set 6 12/13/21, 10:45

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:379 Reply

    Ack
  16. Christian Kuhn commented on patch set 6 12/13/21, 10:45

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:379 Reply

    yes. will do.
  17. Christian Kuhn commented on patch set 6 12/15/21, 10:58

    Breaking-96107-DeprecatedFunctionalityRemoved.rst:379 Reply

    Done
  18. Benni Mack voted on patch set 6 V +1 CR +1 12/15/21, 12:00

  19. Christian Kuhn uploaded patch set 7 12/15/21, 14:12

  20. Nikita Hovratov voted on patch set 7 V +1 CR +1 12/15/21, 14:13

  21. Benni Mack voted on patch set 7 V +2 CR +2 12/15/21, 14:14

  22. core-ci voted on patch set 7 V +1 12/15/21, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21130

  23. Christian Kuhn voted on patch set 7 V +2 CR +2 12/15/21, 14:57

  24. Christian Kuhn merged patch set 8 12/15/21, 14:57