Review main Merged

72596[BUGFIX] Lower log level of TSFE->set_no_cache in preview mode

Rémy DANIEL CR +2 V +2 Easy +1 −1 updated 12/10/21, 09:54

Commit message

If TSFE->set_no_cache is called, either a warning or a notice is triggered,
depending if a BE user is connected or not.
With this change, the preview mode will trigger a notice instead of a warning.

This restores the same behaviour than before #86002.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1118

  1. Rémy DANIEL uploaded patch set 1 12/09/21, 14:46

  2. Rémy DANIEL uploaded patch set 2 12/09/21, 14:49

  3. Rémy DANIEL updated the commit message in patch set 3 12/09/21, 15:02

  4. Benni Mack commented on patch set 3 12/09/21, 15:07

    We do not publish any 9.5 version anymore, so I will remove this from the commit message.
  5. Benni Mack updated the commit message in patch set 4 12/09/21, 15:07

  6. Rémy DANIEL commented on patch set 4 12/09/21, 15:17

    Reply

    Of course... Thanks.
  7. core-ci voted on patch set 1 V -1 12/09/21, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20868

  8. core-ci voted on patch set 4 V -1 12/09/21, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20871

  9. core-ci voted on patch set 2 V -1 12/09/21, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20869

  10. core-ci voted on patch set 3 V -1 12/09/21, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20870

  11. core-ci voted on patch set 3 V -1 12/09/21, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20870

  12. core-ci commented on patch set 4 12/09/21, 15:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20871

  13. core-ci voted on patch set 4 V +1 12/09/21, 18:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20871

  14. Benni Mack voted on patch set 4 V +1 CR +1 12/10/21, 08:28

  15. Stefan Bürk voted on patch set 4 CR +1 12/10/21, 09:49

  16. Stefan Bürk voted on patch set 4 V +1 12/10/21, 09:51

  17. Benni Mack voted on patch set 4 V +2 CR +2 12/10/21, 09:54

  18. Benni Mack merged patch set 5 12/10/21, 09:54