Review main Merged

72597[BUGFIX] Respect single tags without white space

Albrecht Köhnlein CR +2 V +2 Easy +35 −1 updated 12/10/21, 09:58

Commit message

Make HTML parser more tolerant for single tags with ending slash but
without white spaces. So `<hr/>` already was allowed and internally
converted to `<hr />` while parsing the HTML. This patch extends this
replace rule to all tags so that also `<br/>` can be used in RTE fields.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 711

  1. Albrecht Köhnlein uploaded patch set 1 12/09/21, 15:48

  2. core-ci voted on patch set 1 V -1 12/09/21, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20872

  3. core-ci commented on patch set 1 12/09/21, 16:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20872

  4. core-ci voted on patch set 1 V +1 12/09/21, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20872

  5. Benni Mack commented on patch set 1 12/09/21, 19:33

    What happens to <hr class="hide"/> ?
  6. Benni Mack commented on patch set 1 V +1 CR +1 12/09/21, 19:36

    Looks like a separate issue...
  7. Albrecht Köhnlein uploaded patch set 2 12/09/21, 20:34

  8. core-ci voted on patch set 2 V +1 12/09/21, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20893

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 12/10/21, 09:55

  10. Benni Mack voted on patch set 2 V +2 CR +2 12/10/21, 09:58

  11. Benni Mack merged patch set 3 12/10/21, 09:58