Review main Merged

72600[FOLLOWUP] Fix exception with composer installers 3.x

Helmut Hummel CR +2 V +2 Easy +3 −2 updated 12/09/21, 19:56

Commit message

Fix condition that checks the extension type, to only
re-throw the exception when an extension does not define
an extension key.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • Benni Mack +1
    • Altan Tosun +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Simon Gilli +1
    • Benni Mack +1
    • Altan Tosun +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Helmut Hummel uploaded patch set 1 12/09/21, 16:35

  2. Benni Mack voted on patch set 1 V +1 CR +1 12/09/21, 16:45

  3. Benni Mack commented on patch set 1 12/09/21, 16:49

    I suggest to merge this as soon as possible also in v11, so I can test this again in 11.5.x-dev
  4. core-ci voted on patch set 1 V -1 12/09/21, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20875

  5. Helmut Hummel voted on patch set 1 V +2 CR +2 12/09/21, 17:01

  6. Altan Tosun commented on patch set 1 V +1 CR +1 12/09/21, 17:02

    Just tested it, works.
  7. Simon Gilli voted on patch set 1 V +1 CR +1 12/09/21, 17:05

  8. Simon Gilli commented on patch set 1 12/09/21, 17:24

    Reply

    Agree. Will do the same tomorrow, if merged, with my current project.
  9. core-ci voted on patch set 1 V +1 12/09/21, 18:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20875

  10. Helmut Hummel merged patch set 2 12/09/21, 19:56