Review main Merged Breaking

72601[!!!][TASK] Make PSR-7 ServerRequest object required for arguments

Benni Mack CR +2 V +2 Normal +33 −39 updated 12/09/21, 22:46

Commit message

This change modifies various places to always have
a valid PSR-7 Request object handed in.

Previously this was optional as part of the backwards-compatibility
in TYPO3 v11.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1016

  1. Benni Mack uploaded patch set 1 12/09/21, 16:59

  2. core-ci voted on patch set 1 V -1 12/09/21, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20876

  3. core-ci commented on patch set 1 12/09/21, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20876

  4. Benni Mack uploaded patch set 2 12/09/21, 19:28

  5. core-ci voted on patch set 2 V +1 12/09/21, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20888

  6. Benni Mack uploaded patch set 3 12/09/21, 21:57

  7. Benni Mack commented on patch set 4 12/09/21, 21:58

    Published edit on patch set 3.
  8. core-ci voted on patch set 3 V -1 12/09/21, 22:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20900

  9. core-ci voted on patch set 4 V +1 12/09/21, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20901

  10. Oli Bartsch uploaded patch set 5 12/09/21, 22:24

  11. Oli Bartsch voted on patch set 5 V +1 CR +1 12/09/21, 22:24

  12. Stefan Bürk voted on patch set 5 V +1 CR +1 12/09/21, 22:37

  13. core-ci voted on patch set 5 V +1 12/09/21, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20906

  14. Wouter Wolters voted on patch set 5 CR +1 12/09/21, 22:45

  15. Benni Mack voted on patch set 5 V +2 CR +2 12/09/21, 22:46

  16. Benni Mack merged patch set 6 12/09/21, 22:46