Review main Merged Breaking

72602[!!!][TASK] Harden TimeTracker

Benni Mack CR +2 V +2 Normal +56 −119 updated 12/10/21, 08:12

Commit message

This change introduces strict types for the TimeTracker
class and its properties, and removes the legacy logging
options in favor of PSR-3 LogLevels.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Benni Mack uploaded patch set 1 12/09/21, 17:06

  2. core-ci voted on patch set 1 V -1 12/09/21, 17:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20877

  3. core-ci commented on patch set 1 12/09/21, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20877

  4. Benni Mack commented on patch set 2 12/09/21, 19:37

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 12/09/21, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20889

  6. Benni Mack uploaded patch set 3 12/09/21, 22:07

  7. Benni Mack uploaded patch set 4 12/09/21, 22:07

  8. core-ci voted on patch set 3 V +1 12/09/21, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20902

  9. core-ci voted on patch set 4 V +1 12/09/21, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20903

  10. Wouter Wolters voted on patch set 4 CR +1 12/09/21, 22:49

  11. Stefan Bürk voted on patch set 4 CR +1 12/09/21, 22:59

  12. Stefan Bürk voted on patch set 4 V +1 12/09/21, 23:11

  13. Georg Ringer voted on patch set 4 V +2 CR +2 12/10/21, 08:12

  14. Georg Ringer merged patch set 5 12/10/21, 08:12