Review main Merged Breaking

72605[!!!][TASK] Remove unused updateRootlineData method

Benni Mack CR +2 V +2 Normal +50 −80 updated 12/14/21, 17:10

Commit message

The method TemplateService->updateRootlineData() can
be removed. Until TYPO3 v11 TemplateService resolved
the TypoScript for a specific page, then found out the
actual used language (config.sys_language_uid via
TSFE->settingLanguage()) and then fetched the (translated)
rootline based on the resolved language information.

This is not needed anymore, as settingLanguage() does not
call this method anymore, and is called much earlier now,
see https://review.typo3.org/c/Packages/TYPO3.CMS/+/65044.

TypoScript is now always loaded after a translated
page rootline has been fetched.

This method is now completely unneeded, and is remoevd
without replacement as the concept has now been
streamlined.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 813

  1. Benni Mack uploaded patch set 1 12/09/21, 17:35

  2. core-ci voted on patch set 1 V -1 12/09/21, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20880

  3. core-ci voted on patch set 1 V +1 12/09/21, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20880

  4. Benni Mack updated the commit message in patch set 2 12/14/21, 12:53

  5. core-ci voted on patch set 2 V +1 12/14/21, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21078

  6. Benni Mack updated the commit message in patch set 3 12/14/21, 14:31

  7. core-ci voted on patch set 3 V +1 12/14/21, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21087

  8. Benni Mack uploaded patch set 4 12/14/21, 15:19

  9. core-ci voted on patch set 4 V +1 12/14/21, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21091

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 12/14/21, 15:36

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 12/14/21, 17:07

  12. Benni Mack voted on patch set 4 V +2 CR +2 12/14/21, 17:10

  13. Benni Mack merged patch set 5 12/14/21, 17:10