Review main Merged Breaking

72606[!!!][TASK] Remove RequireJS module name "Sortable"

Nikita Hovratov CR +2 V +2 Easy +4 −1 updated 12/09/21, 22:21

Commit message

Due to dependencies to a TypeScript @types package
for Sortable.js, the name to access this module had
to be renamed. This patch removes the old name.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Nikita Hovratov uploaded patch set 1 12/09/21, 17:48

  2. core-ci voted on patch set 1 V -1 12/09/21, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20882

  3. core-ci voted on patch set 1 V +1 12/09/21, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20882

  4. Benni Mack voted on patch set 1 V +1 CR +1 12/09/21, 22:15

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 12/09/21, 22:17

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 12/09/21, 22:21

  7. Benjamin Franzke merged patch set 2 12/09/21, 22:21