Review 10.4 Merged

72609[BUGFIX] Avoid fatal error in workspaces module

Benni Mack CR +2 V +2 Easy +2 −3 updated 12/11/21, 09:58

Commit message

This avoids an error-prone AJAX call in the backend module.

This issue does not happen in TYPO3 v11+ anymore, as the
method is not called via AJAX directly anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1216

  1. Benni Mack uploaded patch set 1 12/09/21, 19:47

  2. Benni Mack updated the commit message in patch set 2 12/09/21, 19:47

  3. core-ci voted on patch set 1 V +1 12/09/21, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20890

  4. core-ci voted on patch set 2 V +1 12/09/21, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20891

  5. Benni Mack updated the commit message in patch set 3 12/09/21, 21:32

  6. core-ci voted on patch set 3 V +1 12/09/21, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20895

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 12/09/21, 22:47

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 12/10/21, 00:18

  9. Oliver Klee commented on patch set 3 CR -1 12/10/21, 11:17

    GridDataService.php:789

    We'll also need to update or remove this annotation. (I'm for removing it.)
  10. Benni Mack commented on patch set 4 12/10/21, 11:43

    Published edit on patch set 3.
  11. Benni Mack commented on patch set 4 12/10/21, 11:43

    GridDataService.php:789 Reply

    Done
  12. core-ci voted on patch set 4 V +1 12/10/21, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20931

  13. Oliver Klee voted on patch set 4 CR +1 12/10/21, 12:29

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 12/10/21, 13:03

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 12/11/21, 09:58

  16. Christian Kuhn merged patch set 5 12/11/21, 09:58