72610[BUGFIX] Forward-compatible prepared statement support
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+11 −6
- typo3/sysext/core/Classes/Database/Query/NamedParameterNotSupportedForPreparedStatementException.phpnew+32 −0
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php4+147 −1
- typo3/sysext/core/Classes/Database/Query/UnsupportedPreparedStatementParameterTypeException.phpnew+32 −0
- typo3/sysext/core/Classes/Database/Connection.php+1 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −3
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/Fixtures/DataSet/queryBuilder_preparedStatement.csvnew+9 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/NamedPlaceholderPreparedStatementTest.phpnew+72 −0
- typo3/sysext/core/Tests/Functional/Database/Query/QueryBuilder/PositionPlaceholderPreparedStatementTest.phpnew+307 −0
Review log 2338
Show 713 earlier messages
-
Stefan Bürk uploaded patch set 1 12/09/21, 21:19
-
core-ci voted on patch set 1 V -1 12/09/21, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20894
-
Stefan Bürk uploaded patch set 2 12/09/21, 21:34
-
Stefan Bürk uploaded patch set 3 12/09/21, 21:47
-
core-ci voted on patch set 2 V +1 12/09/21, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20896
-
Stefan Bürk updated the commit message in patch set 4 12/09/21, 21:49
-
Stefan Bürk updated the commit message in patch set 5 12/09/21, 21:55
-
core-ci voted on patch set 4 V +1 12/09/21, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20898
-
core-ci voted on patch set 3 V +1 12/09/21, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20897
-
core-ci voted on patch set 5 V +1 12/09/21, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20899
-
Stefan Bürk uploaded patch set 6 12/11/21, 18:45
-
core-ci voted on patch set 6 V -1 12/11/21, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20986
-
Stefan Bürk uploaded patch set 7 12/11/21, 19:20
-
core-ci voted on patch set 7 V -1 12/11/21, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20988
-
Stefan Bürk uploaded patch set 8 12/11/21, 19:37
-
core-ci voted on patch set 8 V +1 12/11/21, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20989
-
Lina Wolf commented on patch set 8 12/12/21, 09:38
Following this Change to update the documentation at https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Database/Statement/Index.html#re-use-prepared-statement -
Stefan Bürk uploaded patch set 9 12/18/21, 22:21
-
Stefan Bürk updated the commit message in patch set 10 12/18/21, 22:22
-
core-ci voted on patch set 9 V -1 12/18/21, 22:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21244
-
core-ci voted on patch set 10 V -1 12/18/21, 22:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21245
-
core-ci commented on patch set 10 12/18/21, 23:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21245
-
Stefan Bürk uploaded patch set 11 12/19/21, 15:35
-
core-ci voted on patch set 11 V +1 12/19/21, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21255
-
Sybille Peters wrote 12/20/21, 10:05
Removed cc Sybille Peters. -
Benni Mack updated the commit message in patch set 12 12/20/21, 12:16
-
Benni Mack voted on patch set 12 CR +1 12/20/21, 12:16
-
core-ci voted on patch set 12 V +1 12/20/21, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21275
-
Benni Mack voted on patch set 12 V +1 12/20/21, 12:33
-
Christian Kuhn commented on patch set 12 12/20/21, 13:50
let's give this patch some wording finish ... will take care soon if nobody is quicker.QueryBuilder.php:213do not has?QueryBuilder.php:216drop ', we add this.'. -
Benni Mack commented on patch set 13 12/20/21, 13:56
Published edit on patch set 12. -
Benni Mack commented on patch set 13 12/20/21, 13:56
QueryBuilder.php:213ReplyDoneQueryBuilder.php:216ReplyDone -
Stefan Bürk commented on patch set 14 12/20/21, 14:05
Published edit on patch set 13. -
Christian Kuhn voted on patch set 14 V +1 CR +1 12/20/21, 14:07
-
core-ci voted on patch set 13 V +1 12/20/21, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21284
-
core-ci voted on patch set 14 V +1 12/20/21, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21286
-
Benni Mack voted on patch set 14 V +2 CR +2 12/20/21, 14:25
-
Benni Mack merged patch set 15 12/20/21, 14:25