Review main Merged

72610[BUGFIX] Forward-compatible prepared statement support

Stefan Bürk CR +2 V +2 Hard +617 −10 updated 12/20/21, 14:25

Commit message

doctrine/dbal:^3.2 changed return type of result for QueryBuilder
execute methods, no longer have used prepared statement accessible
for further query execution with other placeholder values.

To raise doctrine/dbal:^3.2 two places have been changed to reuse
the QueryBuilder instance itself instead of prepared statement with
the corresponding patch #96287, thus given up the performance gain
through reusable query execution plan in corresponding dbms systems.

This patch adds support for prepared statements to TYPO3's
QueryBuilder facade as this was not publicly available yet
for TYPO3 users to be forward-compatible with Doctrine DBAL 3.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 9

Review log 2338

Show 713 earlier messages
  1. Stefan Bürk uploaded patch set 1 12/09/21, 21:19

  2. core-ci voted on patch set 1 V -1 12/09/21, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20894

  3. Stefan Bürk uploaded patch set 2 12/09/21, 21:34

  4. Stefan Bürk uploaded patch set 3 12/09/21, 21:47

  5. core-ci voted on patch set 2 V +1 12/09/21, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20896

  6. Stefan Bürk updated the commit message in patch set 4 12/09/21, 21:49

  7. Stefan Bürk updated the commit message in patch set 5 12/09/21, 21:55

  8. core-ci voted on patch set 4 V +1 12/09/21, 22:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20898

  9. core-ci voted on patch set 3 V +1 12/09/21, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20897

  10. core-ci voted on patch set 5 V +1 12/09/21, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20899

  11. Stefan Bürk uploaded patch set 6 12/11/21, 18:45

  12. core-ci voted on patch set 6 V -1 12/11/21, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20986

  13. Stefan Bürk uploaded patch set 7 12/11/21, 19:20

  1. core-ci voted on patch set 7 V -1 12/11/21, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20988

  2. Stefan Bürk uploaded patch set 8 12/11/21, 19:37

  3. core-ci voted on patch set 8 V +1 12/11/21, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20989

  4. Lina Wolf commented on patch set 8 12/12/21, 09:38

  5. Stefan Bürk uploaded patch set 9 12/18/21, 22:21

  6. Stefan Bürk updated the commit message in patch set 10 12/18/21, 22:22

  7. core-ci voted on patch set 9 V -1 12/18/21, 22:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21244

  8. core-ci voted on patch set 10 V -1 12/18/21, 22:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21245

  9. core-ci commented on patch set 10 12/18/21, 23:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21245

  10. Stefan Bürk uploaded patch set 11 12/19/21, 15:35

  11. core-ci voted on patch set 11 V +1 12/19/21, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21255

  12. Sybille Peters wrote 12/20/21, 10:05

    Removed cc Sybille Peters.
  13. Benni Mack updated the commit message in patch set 12 12/20/21, 12:16

  14. Benni Mack voted on patch set 12 CR +1 12/20/21, 12:16

  15. core-ci voted on patch set 12 V +1 12/20/21, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21275

  16. Benni Mack voted on patch set 12 V +1 12/20/21, 12:33

  17. Christian Kuhn commented on patch set 12 12/20/21, 13:50

    let's give this patch some wording finish ... will take care soon if nobody is quicker.

    QueryBuilder.php:213

    do not has?

    QueryBuilder.php:216

    drop ', we add this.'.
  18. Benni Mack commented on patch set 13 12/20/21, 13:56

    Published edit on patch set 12.
  19. Benni Mack commented on patch set 13 12/20/21, 13:56

    QueryBuilder.php:213 Reply

    Done

    QueryBuilder.php:216 Reply

    Done
  20. Stefan Bürk commented on patch set 14 12/20/21, 14:05

    Published edit on patch set 13.
  21. Christian Kuhn voted on patch set 14 V +1 CR +1 12/20/21, 14:07

  22. core-ci voted on patch set 13 V +1 12/20/21, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21284

  23. core-ci voted on patch set 14 V +1 12/20/21, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21286

  24. Benni Mack voted on patch set 14 V +2 CR +2 12/20/21, 14:25

  25. Benni Mack merged patch set 15 12/20/21, 14:25