Review main Merged Breaking

72611[!!!][TASK] Require LinkResultInterface for generating typolinks

Benni Mack CR +2 V +2 Normal +6 −56 updated 12/10/21, 09:21

Commit message

The abstract AbstractTypolinkBuilder class change now
requires all subclasses to require a LinkResultInterface.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 69

  1. Benni Mack uploaded patch set 1 12/09/21, 22:14

  2. core-ci voted on patch set 1 V +1 12/09/21, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20904

  3. Benni Mack uploaded patch set 2 12/10/21, 08:13

  4. core-ci voted on patch set 2 V +1 12/10/21, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20911

  5. Stefan Bürk updated the commit message in patch set 3 12/10/21, 08:36

  6. core-ci voted on patch set 3 V +1 12/10/21, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20912

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 12/10/21, 09:04

  8. Oli Bartsch voted on patch set 3 V +2 CR +2 12/10/21, 09:21

  9. Oli Bartsch merged patch set 4 12/10/21, 09:21